Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: modify the error message of insert time value #20847

Merged
merged 15 commits into from
Nov 6, 2020
Merged

executor: modify the error message of insert time value #20847

merged 15 commits into from
Nov 6, 2020
+16 −5

Conversation

ou-bing
Copy link
Contributor

@ou-bing ou-bing commented Nov 4, 2020 •
edited
Loading

What problem does this PR solve?

Issue Number: close #20207

Problem Summary:

What is changed and how it works?

What's Changed:

Change error code and error info when insert time value.

Check List

Tests

  • Unit test

Release note

  • Change error code and error info when insert time value.

@ou-bing ou-bing requested a review from a team as a code owner November 4, 2020 15:26
@ou-bing ou-bing requested review from lzmhhh123 and removed request for a team November 4, 2020 15:26
@ti-srebot ti-srebot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Nov 4, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Nov 4, 2020

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@github-actions github-actions bot added the sig/execution SIG execution label Nov 4, 2020
@ou-bing
Copy link
Contributor Author

ou-bing commented Nov 4, 2020

@lzmhhh123 I fixed it.

@lzmhhh123
Copy link
Contributor

/rebuild

lzmhhh123
lzmhhh123 reviewed Nov 5, 2020
View reviewed changes
executor/insert_common.go Outdated Show resolved Hide resolved
lzmhhh123
lzmhhh123 reviewed Nov 5, 2020
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 5, 2020
@lzmhhh123
Copy link
Contributor

/cc @ichn-hu

@ti-srebot ti-srebot requested a review from ichn-hu November 5, 2020 05:04
@lzmhhh123
Copy link
Contributor

/reward 300

@ti-challenge-bot
Copy link

Reward success.

@ichn-hu ichn-hu mentioned this pull request Nov 5, 2020
Closed
ichn-hu
ichn-hu previously approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@ichn-hu ichn-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Nov 5, 2020
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 20196
  • 20521

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@ou-bing merge failed.

@lzmhhh123
Copy link
Contributor

/run-all-tests

lzmhhh123
lzmhhh123 reviewed Nov 6, 2020
View reviewed changes
executor/insert_common.go Outdated Show resolved Hide resolved
@lzmhhh123
Copy link
Contributor

/run-common-test tidb-test=pr/1099
/run-integration-common-test tidb-test=pr/1099

@ou-bing ou-bing dismissed stale reviews from ti-srebot and ichn-hu via db7bd3d November 6, 2020 06:05
@lzmhhh123
Copy link
Contributor

/run-common-test tidb-test=pr/1099
/run-integration-common-test tidb-test=pr/1099

@lzmhhh123
Copy link
Contributor

/run-common-test tidb-test=pr/1099
/run-integration-common-test tidb-test=pr/1099

1 similar comment
@lzmhhh123
Copy link
Contributor

/run-common-test tidb-test=pr/1099
/run-integration-common-test tidb-test=pr/1099

lzmhhh123
lzmhhh123 reviewed Nov 6, 2020
View reviewed changes
executor/insert_common.go Outdated Show resolved Hide resolved
@lzmhhh123
Copy link
Contributor

/run-common-test tidb-test=pr/1099
/run-integration-common-test tidb-test=pr/1099

@lzmhhh123
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 20852

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@ou-bing merge failed.

@lzmhhh123 lzmhhh123 merged commit bacd348 into pingcap:master Nov 6, 2020
@ti-challenge-bot
Copy link

@ou-bing, Congratulations, you get 300 in this PR, and your total score is 300 in challenge program.

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Nov 6, 2020
@ou-bing @ti-srebot
cherry pick pingcap#20847 to release-4.0
ba24765 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Nov 6, 2020
Closed
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #20898

@ou-bing ou-bing deleted the bug-fix/20207 branch November 6, 2020 08:46
@ichn-hu ichn-hu mentioned this pull request Sep 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

@ti-srebot ti-srebot ti-srebot left review comments

@ichn-hu ichn-hu ichn-hu left review comments

Assignees
No one assigned
Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Different error code from MySQL when inserting incorrect time value
5 participants
@ou-bing @sre-bot @lzmhhh123 @ti-srebot @ichn-hu